Hi.
There are so many annoying PHP-warnings and notices running your code.
How about improving the following aspects:
1.) Don't access uninitialized array members (or initialize all of them at creation time)
2.) replace old syntax for accessing associative arrays (e.g. write $x['info'] instead of $x[info] or {$x['info']} inside of a double-quoted string) this could quite easily be done with some regular expression replacement in my opinion
3.) Don't rely on registerglobals. docs say you need registerglobals on with your code. accessing the superglobals $_GET, $_POST, $_REQUEST, $_COOKIE,... directly would rule much more ;). I don't know anybody still running PHP 3.
4.) not sure if this is already implemented, but your docs also say that you're required to have magic_quotes_gpc set to a specific value; there's also some very simple fix for that issue that i've already seen somewhere on this site.
Greetings
Wolfgang
Login
Donate to Zikula
Feedback & Suggestions
::
compatibility extension (PHP-code quality)
Users online
- Guite,
- HalbrookTech,
- Simon,
- Topiatic,
- claus.parkhoi,
- damon,
- davidnelson,
- jaenosjelantru,
- jami,
- kylegio,
- mdee24,
- philipp,
- quan
