Zikula Community

• krator
  
  

  • Rank: Softmore
  • Registered: Jan 29, 2009
  • Last visit: May 31, 2010
  • Posts: 136

  Posted: Mar 19, 2012 - 11:13 PM

  Hi everybody.
  
  Zikula 1.2.8.
  I was modifying a custom module for new requeriments. I needed a field with the name "SET", so, in pntables.php, I added a new field with this name, but when i used in pninit.php the sentence:
  

  Code

  if (!DBUtil::changeTable('my_table')) {
        return false;
  }

  
  In the update module, the process return the message error:
  

  Code

  Error! Actualización de tabla fallida. (my_table, 1, 0 - )
  Error! Update of table

  
  Using the file "DBUtil.class.php" and a lines with print and die, i can see that the ChangeTable use the sentence
  

  Code

  ALTER TABLE my_table MODIFY COLUMN set INTEGER

  
  I can see that mysql "use" "set" how an own sentence and this is the reason for the error.
  If the line was:
  

  Code

  ALTER TABLE my_table MODIFY COLUMN `set` INTEGER

  
  the problem will be fixed.
  
  I hope that this problem can help to others developers and this "error" can be fixed in a future (ZK 1.2.9?)
  
  Thanks for all.

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Last visit: May 29, 2010
  • Posts: 2215

  Posted: Mar 20, 2012 - 12:19 AM

  'SET" is a MySQL reserved word. I would suggest a different name.

  • 
  •  
• krator
  
  

  • Rank: Softmore
  • Registered: Jan 29, 2009
  • Last visit: May 31, 2010
  • Posts: 136

  Posted: Mar 20, 2012 - 07:39 PM

  Yes, I know, but you can use the name "set" in tables. The problem is that the sentence that Zikula create with DBUtil do not use ` ` when use the fields. So, this sentence:
  

  Code

  ALTER TABLE my_table MODIFY COLUMN `set` INTEGER

  
  Can be used (and others examples).
  
  Thanks.

  • 
  •  
• nestormateo
  
  

  • Rank: Team Member
  • Registered: Sep 06, 2006
  • Last visit: May 09, 2010
  • Posts: 2447

  Posted: Mar 21, 2012 - 06:17 AM

  adoDB and Doctrine assumes that you don't use reserved words,
  that why they doesn't sanitize that stuff
  
  --
  - Mateo T. -
  Mis principios... son mis fines

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Last visit: May 29, 2010
  • Posts: 2215

  Posted: Mar 21, 2012 - 09:08 AM

  if you use doctrine you can fix the problem yourself.

  • 
  •  
•  
•  

Users on-line

• DirkThiele

This list is based on users active over the last 60 minutes.