Zikula Community

• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Last visit: May 29, 2010
  • Posts: 1966

  Posted: Dec 07, 2009 - 09:46 AM

  Should a module delete categories it created upon uninstall?

  • 
  •  
• Guite
  
  

  • Rank: Team Member
  • Registered: Jan 19, 2003
  • Last visit: Apr 06, 2010
  • Posts: 442

  Posted: Dec 07, 2009 - 10:04 AM

  My personal opinion is no. The dev can not assume that the categories are not used by other modules or category registries. But hey, the best solution is probably to use interactive uninstall procedure and ask the admin
  
  --
  Guite | ModuleStudio

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Last visit: May 29, 2010
  • Posts: 1966

  Posted: Dec 07, 2009 - 02:00 PM

  I would tend to agree with the premise, but what about the registry entry? Surely, that should be deleted?
  
  I am working on my delete routine and trying to remove category registry entries. I've copied the delete routine from News (same as Pages, etc).
  
  Anyway - it doesn't work!
  
  

  Code

  // Delete entries from category registry
      pnModDBInfoLoad ('Categories');
      Loader::loadArrayClassFromModule('Categories', 'CategoryRegistry');
      $registry = new PNCategoryRegistryArray();
      $registry->deleteWhere ('crg_modname=\'PostCalendar\'');

  
  
  I tried to trace it, but am not fluent in OO. I think that the deleteWhere method is returned as false because the deletePreProcess method is not defined in PNCategoryRegistryArray class. therefore, the routine silently fails.
  
  ideas?

  • 
  •  
•  
•  

Users on-line

• 0 users

This list is based on users active over the last 60 minutes.