Zikula Community

• mattlt
  
  

  • Rank: Registered User
  • Registered: Jun 13, 2004
  • Last visit: Feb 27, 2010
  • Posts: 45

  Posted: Dec 17, 2008 - 08:15 PM

  I am unable to add a ticket to the Cozi, so I'm posting here.
  
  Currently when calling a block position with multiple blocks, it is output like so?
  
  

  Code

  <div class="pn-block pn-blockposition-example pn-bkey-example pn-bid-1">
      Block content
  </div>
  <div class="pn-block pn-blockposition-example pn-bkey-example pn-bid-2">
      Block content
  </div>

  
  
  Shouldn't the PN-blockposition-example be a wrapper for all the blocks in the position so it is output like so?
  
  

  Code

  <div class="pn-blockposition-example">
      <div class="pn-block pn-bkey-example pn-bid-1">
          Block content
      </div>
      <div class="pn-block pn-bkey-example pn-bid-2">
          Block content
      </div>
  </div>

  
  
  It would make styling easier, for example if I want to float a blockposition. Now, I need to wrap the blockposition tag in a wrapper of my own. If there are no blocks assigned to the particular blockposition I get an empty div.
  
  I have a new function.blockposition.php file with my changes if interested.
  
  Thanks,
  
  matt
  
  --
  The Peripheral Vision
  Creative Culture : Business : Technology
  www.theperipheralvision.com

  • 
  •  
• nestormateo
  
  

  • Rank: Team Member
  • Registered: Sep 06, 2006
  • Last visit: May 09, 2010
  • Posts: 2446

  Posted: Dec 18, 2008 - 01:39 AM

  Nice point,
  that needs a change in pnTheme.class.php -> themesidebox method too, to remove the class of the block wrapper.
  
  The problem will be consistency.
  Recently, in 1.1 was added the possibility to not implode the blocks and let us handle them individually, something like:
  

  Code

  <!--[pnblockposition name='PositionName' implode=false assign='BlockArray']-->

  
  and put anywhere you like each block of that Block Position with:
  

  Code

  <!--[$BlockArray.0]--> ... <!--[$BlockArray.2]-->

  
  so, a DIV wrapper should be added when imploding the blocks ONLY.
  it's better to handle it "manually" at theme level IMHO,
  Would be nice to generate the wrapper without consistency problems
  
  I see now the ticket
  http://code.zikula.org/core/ticket/709
  was created many times due the datacenter maintenance. Are you in the mailing list, if not: join it !
  http://groups.google.com/group/zikula-discussions
  
  --
  - Mateo T. -
  Mis principios... son mis fines

  • 
  •  
• mattlt
  
  

  • Rank: Registered User
  • Registered: Jun 13, 2004
  • Last visit: Feb 27, 2010
  • Posts: 45

  Posted: Dec 18, 2008 - 02:27 AM

  Sorry about the multiple tickets. I got an error each time and didn't realize it was going through. Had an Ajax error twice here in the forums, but it looks like both those posts took also.
  
  
  

  Quote

  
  it's better to handle it "manually" at theme level IMHO,
  Would be nice to generate the wrapper without consistency problems
  

  
  
  Cool beans. The geeky side of me give a +1 to 'manually', but then my deal with clients side comes into play. Scary. We have enough trouble getting them to edit a page with a WYSIWYG editor. Hopefully this can be integrated somehow.
  
  I follow the Google group via RSS but am not a member. Maybe one of these days I'll create yet another Google account I'll need to remember to log out of. Why can't that stuff be here in the forums?
  
  Thanks,
  
  matt
  
  --
  The Peripheral Vision
  Creative Culture : Business : Technology
  www.theperipheralvision.com

  • 
  •  
•  
•  

Users on-line

• rgasch

This list is based on users active over the last 60 minutes.