Zikula Community

• mumuri
  
  

  • Rank: Developer
  • Registered: May 17, 2004
  • Last visit: Apr 08, 2010
  • Posts: 386

  Posted: May 12, 2008 - 07:02 AM

  Hello
  
  i would like to know why there is no method FormUtil::getPassedValues with the content from pnVarCleanFromInput in it ? is it for performance ?
  
  because if an existing module is using something like list(...)= pnVarCleanFromInput(), il would be much easier to upgrade this part of the code to pn0.8 ?

  • 
  •  
• Guite
  
  

  • Rank: Team Member
  • Registered: Jan 19, 2003
  • Last visit: Apr 06, 2010
  • Posts: 442

  Posted: May 12, 2008 - 07:42 AM

  Hi mumuri.
  
  I do not know it exactly, but I guess this is related to the fact that the new methods are array-safe.
  
  --
  Guite | ModuleStudio

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: May 12, 2008 - 07:38 PM

  pnVarCleanFromInput only takes one parameter (the variable name) where as getPassedValue takes 4. Logically a method, getPassedValues, should be a multiple execution of getPassedValue which wouldn't be possible to implement given the multiple parameters getPassedValue takes.
  
  Encouraging 3rd party developers to split existing pnVarCleanFromInput statements into getPassedValue method calls encourages them to use the other parameters to further restrict input. IMO this is a good thing.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• nestormateo
  
  

  • Rank: Team Member
  • Registered: Sep 06, 2006
  • Last visit: May 09, 2010
  • Posts: 2446

  Posted: May 13, 2008 - 05:09 AM

  And control/safety,
  i see it advantage when some vars comes only on GET (filter view params, and others) and some forms receives only POST parameters. It's a secure practice and also a good thing from my point of view.
  
  --
  - Mateo T. -
  Mis principios... son mis fines

  • 
  •  
•  
•  

Users on-line

• 0 users

This list is based on users active over the last 60 minutes.