pnRender->plugins_dir  Top

  • Jusuff
    Jusuff's Avatar
    Team Member
    • Rank: Team Member
    • Registered: 07.04.05
    • last visit: 18.01.10
    • Posts: 216
    Posted: 27.09.2007, 19:09
    In pnRender.class.php we have defined possible plugins directories.
    They are ordered in this way:

    Code

    'system/pnRender/plugins',
    'system/Theme/plugins',
    'config/plugins',
    "themes/$theme/templates/modules/$module/plugins",
    "themes/$theme/plugins",
    "$modpath/$modinfo[directory]/pntemplates/plugins"

    So priority have plugins placed in pnRender plugins.

    Shouldn't it be config/plugins dir?

    This would gave users possibility to override system (pnRender or Theme) plugins.
    And it would be - in my opinion - more consequent (for example - while searching template, the config path is considered at first place).




    --
    Polish Zikula Team
    Bianor Works - my Zikula works on CoZi
  • markwest
    markwest's Avatar
    Moderator
    • Rank: Moderator
    • Registered: 18.03.02
    • last visit: 21.10.09
    • Posts: 6611
    Posted: 27.09.2007, 19:39
    The directories were ordered this way as a performance measure i.e. the vast majority of plugin calls will be found with very little file system searching.

    -Mark

    --
    Visit My homepage and Zikula themes.
  • nestormateo
    nestormateo's Avatar
    Team Member
    • Rank: Team Member
    • Registered: 06.09.06
    • last visit: 02.03.10
    • Posts: 2140
    Posted: 27.09.2007, 20:08
    That mean that default pnRender and Xanthia (Theme) plugins can't be override from the config folder; that have sense to me not only for the performance priority, but is the better one.

    In a PN Site with very specifics needs to customize the plugins behavior or output it have to be overwrited... no chance, i guess.

    --
    - Mateo T. -
    Mis principios... son mis fines
  • Jusuff
    Jusuff's Avatar
    Team Member
    • Rank: Team Member
    • Registered: 07.04.05
    • last visit: 18.01.10
    • Posts: 216
    Posted: 27.09.2007, 21:45
    Mark: it's quite strange for me.
    Using config directory we can overwrite templates or langs. So why not plugins?

    --
    Polish Zikula Team
    Bianor Works - my Zikula works on CoZi
  • markwest
    markwest's Avatar
    Moderator
    • Rank: Moderator
    • Registered: 18.03.02
    • last visit: 21.10.09
    • Posts: 6611
    Posted: 27.09.2007, 22:04
    Simple - performance!

    In our testing the effect of searching the config, module and theme directories before finally finding each plugin in the pnRender and Theme modules was too great to continue using this setup.

    -Mark

    --
    Visit My homepage and Zikula themes.
  • nestormateo
    nestormateo's Avatar
    Team Member
    • Rank: Team Member
    • Registered: 06.09.06
    • last visit: 02.03.10
    • Posts: 2140
    Posted: 27.09.2007, 22:09
    IMHO this is really needed in a system like PostNuke, that have to balance it performance with the flexibility...

    Take in account that are just the pnRender and 'Xanthia' plugins, not all the plugins.

    --
    - Mateo T. -
    Mis principios... son mis fines
  • Jusuff
    Jusuff's Avatar
    Team Member
    • Rank: Team Member
    • Registered: 07.04.05
    • last visit: 18.01.10
    • Posts: 216
    Posted: 27.09.2007, 23:18
    Maybe you're right...
    At last it isn't big deal to change the name of plugin :)


    --
    Polish Zikula Team
    Bianor Works - my Zikula works on CoZi

Users online

This list is based on the users active over the last 60 minutes.