Fork me on GitHub

db_extra_enable_categorization  Bottom

  • Jusuff
    Jusuff
    Team Member
    • Rank: Team Member
    • Registered: Apr 07, 2005
    • Last visit: Jan 18, 2010
    • Posts: 228
    Link to this post Posted: Aug 14, 2007 - 08:25 PM
    We can enable categorization by setting in pntable array new entry:

    Code

    $pntable[{modname}_db_extra_enable_categorization]


    And there is some inaccuracy. In DBUtil class or in some ValueAddons modules which are using new category system (Pages, News, FAQ).

    What inaccuracy?
    In Pages module in pntable.php we can find:

    Code

    // Enable categorization services
        $pntable['pages_db_extra_enable_categorization'] = pnModGetVar('Pages', 'enablecategorization');

    So categorization should be enabled only when suitable module variable is set to "true".

    But DBUtil class does not check if "pages_db_extra_enable_categorization" entry is set to true or false. If this entry is set (end even if its value is false) categorization is enabled.
    Code looks like this:

    Code

    if ( ( isset($pntables["{$tablename}_db_extra_enable_all"]) ||
                   isset($pntables["{$tablename}_db_extra_enable_categorization"]) ) &&


    So I think there is error somewhere - in DBUtil class or in value addons modules.

    --
    Polish Zikula Team
    Bianor Works - my Zikula works on CoZi
  • Guite
    Guite
    Team Member
    • Rank: Team Member
    • Registered: Jan 19, 2003
    • Last visit: Apr 06, 2010
    • Posts: 442
    Link to this post Posted: Aug 14, 2007 - 08:48 PM
    IMHO this is a bug - could you please open an entry within the tracker, please?

    --
    Guite | ModuleStudio
  • Landseer
    Landseer
    Team Member
    • Rank: Team Member
    • Registered: Jan 02, 2003
    • Last visit: Oct 21, 2009
    • Posts: 800
    Link to this post Posted: Aug 15, 2007 - 08:13 PM
    The attribution, meta and logging additions need to be checked too as they use the same lines of code in DBUtil.



    --
    "He is not dangerous, he just wants to play...."
  • Jusuff
    Jusuff
    Team Member
    • Rank: Team Member
    • Registered: Apr 07, 2005
    • Last visit: Jan 18, 2010
    • Posts: 228
    Link to this post Posted: Aug 19, 2007 - 05:10 AM
    Ok - I've submitted this issue on bug tracker

    --
    Polish Zikula Team
    Bianor Works - my Zikula works on CoZi

Users on-line

This list is based on users active over the last 60 minutes.