- Moderated by:
- Support
-
- rank:
-
Freshman
- registered:
- May 2004
- Status:
- offline
- last visit:
- 06.04.07
- Posts:
- 34
I used the patch files to update my 0.762 to 0.763 and it has pretty much been fine. Just two things I noticed:
1) Not all the files included in the patch were really updated, so it's bigger than it really needs to be. Since I have modified a lot of the standard files I spent a lot of time doing diffs on the contents before applying the patches. In the course of doing that I discovered than many files simply had their initial version comment line changed, and nothing else. Hopefully in the future this can be addressed so that patch files are kept to the minimum size needed to actually do a patch, without all this extra redundant stuff.
2) It seems now that images can't be displayed inline (using the img tag) in weblink comments as of 0.763. This worked fine in 0.762 and was something I made use of. Is there a new way to do this, or a simple fix? -
- rank:
-
Steering Committee
- registered:
- December 2002
- Status:
- online
- Posts:
- 13418
1) The patches are created by taking all files from SVN that have been revised since the last release. One reason the patched distributions are so large is that they tend to contain updates to ADODB and Smarty which bloat the packages somewhat.
2) Are you formatting the image tag properly, quoting all attribute/value pairs?
--
Regards,
Simon
itbegins.co.uk - Zikula Consulting
Please read the Support Guide -
- rank:
-
Freshman
- registered:
- May 2004
- Status:
- offline
- last visit:
- 06.04.07
- Posts:
- 34
1) A suggestion then would be to not update the version line in a file (thereby changing it in SVN and making it flagged for inclusion in the patch) unless the file has actually changed. This would help cut down on the size. An example is admin.php where the only change is the first line:
// File: $Id: admin.php,v 1.28 2006/01/13 19:16:15 jorg Exp $
changed to:
// File: $Id: admin.php 17588 2006-01-13 19:16:15Z jorg $
No other part of the file differed. But that enough caused it to be included. There are a lot of other files like that.
2) Has something changed between 0.762 and 0.763? The problem is that the code is now being quoted, instead of interpreted by the browser as HTML. It was working fine in 0.762. For example, in the description of a weblink to Amazon, I'd use the following to display an image of the book cover:
Code
<img src="http://ec3.images-amazon.com/images/P/1886411743.01._BO2,204,203,200_PIsitb-dp-500-arrow,TopRight,45,-64_AA240_SH20_SCLZZZZZZZ_.jpg" alt="Absolute BSD" /><br />
by Michael Lucas, Jordan Hubbard (Foreword)<br />
Publisher: No Starch Press; (August 2002)<br />
ISBN: 1886411743
In 0.762 that worked just fine. With no changes to my site however, after upgrading to 0.763 this now gets sent to the browser as:
Code
<img src="http://ec3.images-amazon.com/images/P/1886411743.01._BO2,204,203,200_PIsitb-dp-500-arrow,TopRight,45,-64_AA240_SH20_SCLZZZZZZZ_.jpg" alt="Absolute BSD" /><br />
by Michael Lucas, Jordan Hubbard (Foreword)<br />
Publisher: No Starch Press; (August 2002)<br />
ISBN: 1886411743
Which of course won't work. -
- rank:
-
Software Foundation
- registered:
- December 1969
- Status:
- offline
- last visit:
- 15.11.08
- Posts:
- 4481
did you enable the 'img' tag with parameters in administration-settings?
--
regards from germany
..::[Zikula Application Framework]::.. ..::[SEO-Blog]::.. ..::[CMS Sicherheit]::.. -
- rank:
-
Freshman
- registered:
- May 2004
- Status:
- offline
- last visit:
- 06.04.07
- Posts:
- 34
Thanks larsneo, that did it. Somehow IMG got disabled. Did that get changed from the upgrade? I know I had gone through all that when I initially set things up and it was working w/ 0.762 so I didn't think to look again. -
- rank:
-
Steering Committee
- registered:
- December 2002
- Status:
- online
- Posts:
- 13418
Quote
No other part of the file differed. But that enough caused it to be included. There are a lot of other files like that.
That could be a result of the conversion from CVS -> SVN, since SVN follows a different versioning scheme. If that's the case, there won't be a problem in future patches.
--
Regards,
Simon
itbegins.co.uk - Zikula Consulting
Please read the Support Guide
