Zikula Community

• **unknown user**
  
  

  • Rank: Softmore
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 171

  Posted: Oct 03, 2006 - 06:50 AM

  If you do a basic installation of PN 0.8 modules like downloads,faq,reviews aren't installed. However, there are links to these modules in Seabreaze that don't check if the module is active. Voododolly checks if the module is activated and hides the text in the top navigation bar, but the links to news,downloads and weblinks are still there...
  
  I'm not sure if this is wanted. Of course it keeps the templates simpler. But if a novice user installs a basic PN for the first time and is confronted with links that don't work.....
  

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Oct 03, 2006 - 09:44 PM

  tycho,
  
  Different approaches really. The reason voodoodolly and andreas08 don't show the modules is not for the reason you mention. The template logic attempts to get the display name of the module but this fails if the module isn't installed so nothing is displayed.
  
  The templates are just samples and i'd expect this to be one of the first things people change - although the new default themes are a lot nicer than the ones in .7x.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• **unknown user**
  
  

  • Rank: Softmore
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 171

  Posted: Oct 03, 2006 - 11:25 PM

  I agree that changing/adapting the theme is one of the first things people change. But if it where my first postnuke installation i wouldn't want to be confronted with "failing" links in a default installation.
  
  Just took a look at the code and voododolly now has:
  

  Code

  <ul>
   <li class="selected"><a href="<!--[pngetbaseurl]-->">Home</a></li>
   <li><a href="<!--[pnmodurl modname=News]-->"><!--[pnmodgetinfo modname=News info=displayname]--></a></li>
   <li><a href="<!--[pnmodurl modname=Downloads]-->"><!--[pnmodgetinfo modname=Downloads
          info=displayname]--></a></li>
  </ul>

  
  Why not change it to something like :
  

  Code

  <ul>
  <li class="selected"><a href="<!--[pngetbaseurl]-->">Home</a></li>
  <!--[pnmodgetinfo modname=Downloads info=displayname assign=downloadsname]-->
  <!--[if $downloadsname != ""]-->   
          <li><a href="<!--[pnmodurl modname=Downloads]-->"><!--[$downloadsname]--></a></li>
  <!--[/if]-->
  </ul>

  
  
  Untested but this way people won't be confronted with links leading to a "Module not available" page in a default installation.
  
  ps. the new themes are a lot nicer :) Great work!

  • 
  •  
•  
•  

Users on-line

• 0 users

This list is based on users active over the last 60 minutes.