Dizkus

Mark:
There's a detailed changelog in the root of the package, where I posted all the code that was changed with linenumbers. I used it as a bit of a scrapbook in that sense. Some of the linenumbers have changed.

To compensate for having thrown the smaller package together quickly and somewhat haphazardly yesterday (eg I kept the Admin module in since leaving it out requires minor changes elsewhere, and for the Admin stylesheet and Config template etc), I'll detail some of the key changes.

pnMod is simply a changed pnModURL function, which also incorporate the SSL changes better. It allows the use of a Fully-Qualified URL or root-relative URL. If $ssl or $fqurl is set, it generates a full URL.
Then of course there's the ShortURL routine. Only User links are made ShortURL, not Admin or Init, to avoid any problems. SE's have no business in Admin anyway, nor would users post links to it.
For custom ShortURLs, it checks the module dir for shorturls.php. PHP caches the result of file_exists(), so that's only done once in execution. The next 18 lines make the ShortURL and return, else the normal URL routine executes.

pnAPI fixes pnGetBaseURI() and pnRedirect(). The old pnGetBaseURI reported the wrong dir when using virtual directories. pnRedirect now handles Absolute, Root-relative, and File-relative URLs.

Not all the changes in the Xanthia and pnRender modules are necessary, especially as you pointed out the Base tag can take care of paths. So all the BaseURI's added to plugins aren't strictly needed.
The main plugins in pnRender are the open- and closetable functions (bugfix), and pager and pagerabc functions to have them use ModURL when ShortURLs are enabled. I added modifier.htmlspecialchars because pnvarprepfordisplay is widely abused in the templates; having to parse every string and integer for emails with regex and then htmlspecialchars is wasteful. So I've used this modifier for strings, and for integers applied (int) to pnrender assigns and no modifier in the template, to cut down on overhead a bit. I think the pnRender_admin template is just a code cleanup. Since I made pnRedirect able to handle relative, root-relative, and absolute paths, pnRender's pnadmin calls to pnRedirect reflect this change.
includes/pnRender.class.php adds the $baseurl, baseuri($nukepath), and themecolor variables for use in module templates.

The key changes in Xanthia are mainly in Xanthia.php, pnadmin.php and pnadminapi.php, detailed in the changelog. I added baseURI throughout, but also added $baseurl and $nukepath for use in templates.
You may want to revert the code to get the tabs stylesheet in pnadmin starting on line 222. With this fixed, it is independed of the Admin module changes.
There's a change in pnadmin relating to the pagerabc plugin, starting on line 3664, having * for 'all' is a bit geeky, so I enabled the use of "All" which gets rewritten to '*' for use here.
In adminapi there aren't many changes, mainly I changed _getEditTemplate to provide a human-readable timestamp. The rest are minor. Samewith pnuserapi, mainly I provided a friendly error message if for instance a user tried to user &theme=postnukeblue in the URL, which will cause Xanthia's case-sensitive match to fail. This is more an issue on Windows, which has a case-insensitive filesystem, but the PHP code isn't.
The most crucial change to the Xanthia plugins is of course outputfilter.shorturls.php, which is wholly rewritten. I've left older rules commented out if people should need any for a specific older module. Most of the rest are path fixes or unrelated to shortURLs; I just added the whole Xanthia module change from the main package.
I added an alternate displaygreeting plugin, and added ImageAlign as used in SeaBreeze.
The datetime plugin has been modified to accept date modifiers.
function.title is more SEO-friendly, adding Modulename to regular module titles, and Topic to News titles. SE's do look at title keywords, and it's better for users' sanity that not all the Back history links are identical.
I added function.topics, which makes a Topics drop-down menu.
In pndocs, I made a small change to the sample theme.php, also in the root folder themes/, to add base URI to the $themepath variable, even though it appears not to be used anywhere.

Some of the language defines relating to ShortURLs can be removed from Xanthia, since they've been moved to Settings. They're still listed in the changelog. I believe I fixed the odd grammar, a compare should sort that out.

The ShortURL stuff has of course been removed from the config template, and all the others cleaned up with [opentable] and [closetable] and themecolor tags added. To revert to the old tabs menu, xanthiaadminmenu.htm needs to be changed.

That pretty much covers changes to Xanthia and pnRender.

Settings has both a fixed admin.php for the old module and a templated version, so is provided in full. The description in the changelog doesn't contain all the code, since it was a major overhaul.
In pnadmin, the tab stylesheet is set from line 76.
from line 214, you have

setting up template variables for the templates. The ShortURL tab will only show if either the server is Apache, or IIS with Asapi Rewrite (it sets the server variable HTTP_X_REWRITE_URL).
The template settings_admin_main.htm contain the entire Settings panel. I seem to have left some other dead templates in there. Oh well. I did have a non-tabs version, but left it out as it was out of date. If you rip out all the Javascript, you end up with the old look, separated by section. If you turn of JS and reload the page, you'll see what it would look loke. Degrades nicely. You'll find the shortURL tab at line 284 of the template.

Header_Footer has the Base tag applied, using the above $baseurl Xanthia variable:
That takes care of older modules, but not unfixed Xanthia themes. Luckily there aren't many of those, and the addition of the Base tag very minor. For now I've left the Xanthia filter rule to fix paths in (the last rule).

News, Sections, and Topics are older modules, and for the purpose of ShortURLs must be fixed manually, especially to add Titles, eg /Category/Topic/Article123-title.html, /News/Topic2-Postnuke.html, /Sections/Article1-p1-article-name.html
The User module tools.php is fixed with BaseURI to ensure redirection to the right URL, and includes the theme stylesheet. It also has theredirect message in H3 tags with aDIV with id "loading" (I used this style for a container in PostNukeBlue and SeaBreeze for a page loading message). In return, the language define has been tweaked.


I think that's basically it.

msandersen:

Today I set up a test site for your ShortURLS implementation on my personal page, with PostNuke 0.760 RC4 and here is what I found:

1. After replacing the files (I had previously the "old ShortURLS" implementation, using .phtml extension) I wasn't able to go to the admin panel to activate the "enable ShortURLs" option via mysite.com/admin.php . In the main site, on the top of every page I had 4 error messages that said: "No theme colours in database!!!!! skinid=2 pallette=11 Xanthia pnuserapi line 414" so, I had to edit pnuserapi.php file on Xanthia modules directory and comment line 414. After that, I didn't get that error message anymore AND I could enter the admin panel (which, BTW, I had entered already via "index.php?module=Admin&type=admin&func=adminpanel") and activated the ShortURLs option.

2. In general, the news URL work pretty well, except it puts every single character of the news name, which is not bad, but looks weird when it changes the quotation marks (") for &quot and even worse, when it changes the new smilies implementation on the titles for the image URL, which works but you end up with a very strange news name, like: "/Articulos/enemigos/Article337-%A1Una-horda-de-chimpanc%E9s-ataca-ImoqLand!-(Por-culpa-de-%D3scar-%3Cimg-src=%22imagessmiliesicon_razzgif%22-alt=%22Smilie%22-%3E).phtml" which is not very "human readable" anyway :(. The original text says: "¡Una horda de chimpancés ataca ImoqLand! (Por culpa de Óscar )" (notice that the " " gets converted into a "tongue emoticon" by PostNuke, which is good bu it shouldn't be on the URL as "img-src=%22imagessmiliesicon_razzgif%22-alt=%22Smilie". I have seen blogspot's implementation, which basically leaves all the "regular" letters on the titles but trims the special characters; I don't know if it would be better for the ShortURLs approach.

3. This doesn't have to do anything with your implementation, but it's a little bit of help request, in case you can: ShortURLs for Menalto's Gallery no longer works with your implementation :(. What I changed (to leave it the same as it was with the "old ShourtURLs implemenation") is:

in .htaccess, I added:



And in modules/Xanthia/plugins/outputfilter.shorturls.php:

just after $in = array(



and just after $out = array(



(I added the '$1"'.$baseurl just hoping that it worked, just as you have in the other rules in that section).

Those rules work pretty well with the other ShortURLs implementation, but not with yours. I have disabled gallery's ShortURLs for now on the test site.

In case you want to see the difference between two sites, my personal page is:

http://www.imoqland.com/

while the test version with your changes is:

http://test.imoqland.com/

Finally, I just want to thank you for your hard work. I was looking forward for something like this and I think now I have found it :)

Cheers,

Alex.

Cool, it's meant to be tested and debugged. A non-English test site is also useful, which at least proves the urls works with other character sets.
Having the title on the News is an experiment, which many would like, but at the expense of sometimes having long links with long headings.
And it's highlighted one bug as you noticed: Smilie-images in your heading:
/Articulos/enemigos/Article337-%A1Una-horda-de-chimpanc%E9s-ataca-ImoqLand!-(Por-culpa-de-%D3scar-%3Cimg-src=%22imagessmiliesicon_razzgif%22-alt=%22Smilie%22-%3E).phtml
so obviously tags should've been filtered out (currently angle brackets are converted to HTML entities, I figured people might use them for less-than or more-than or as an arrow). Removing matching brackets <...> content might be a solution to that. The Spanish characters show here as entities, but appear right in the browser.
I've enabled the bb-smilie hook for various News modules, but they're old and not Hook-aware, so I've had to enter a link manually to test.

Other titles look ok:
/Articulos/enemigos/Article291-Alzheimer-y-pendejadas-(Actualizado).phtml
Spanish people here can see what the article is about. Something to do with Alzheimer's it seems.

I downloaded and installed Gallery v1.5 specifically to test. I found the integration script tagged on a filename with the extensions .php, which doesn't work with ShortUrls (new or old), so I edited its URL generation to leave the extension out and add it later. I also changed the urls from the old modules.php?op=modload&name=... to the current index,PHP?name=... I notice you're running an unmodified version of Gallery which doesn't have any ShortUrls at all. Notice in the package I had it in a folder called gallery v1.5 with the version number, unlike the other modules, since I haven't tested any other version. If you copy those files across to your Gallery folder (assuming it's the latest v1.5, and probably earlier), then the ShortURLs should work (though not as short). I'll leave people to add their own customised URLs.

The Xanthia error would have been there before, but silently. I merely added the error message that there was no colours in the database. The routine is called 4 times, hence it appears 4 times. It is probably a problem in your theme's xaninit. Xanthia is case-sensitive, so if the theme is called SlackHatBlueX, then that is the case it must appear in everyhere, including the folder.

On your menu, you have an old link: Encuestas links to PN_Polls, not Polls (the NS-prefixes has been removed in pn0.76)


Update: I've now uploaded an update to the pn0.76 package for Example, News, Sections and Topics. It now filters out HTML tags in titles. The Topic module I added titles to ShortURLs, consistent with how they are in the News module. Fixed the Stories block, filtering out tags in story titles.

Updated files (23kb)
pn0.76rc4 ShortURL package (611kb)
pn0.76rc4 ShortURL f…kage (with modules) (1Mb)

Also updated:
PostNukeBlue theme
SeaBreeze theme

I haven't experimented any more with Gallery, but played some more with the News/func.php file, in the Update. The international characters show fine in the browser and in the page source, the problem is that when you Copy Link Location from the browser, it automatically transforms the international characters to Hex codes, so there isn't much I can do about that. It seems to be in the standards. Removing every non-US Ascii character seems extreme. The internet, unfortunately, is based around US English, and specifically US Ascii characters, Internationalisation came later. You still cannot use international (non-English) characters in a Domain name today. Damn Yankees!

msandersen:

First than all, I want to give you a big thank you for helping us, final users, to test and debug your program.

I downloaded your new version and unzipped it on the test directory, changed the .htaccess to ShortURLs.conf (as I instructed my apache to read the rules from there) and restarted the web service, but I don't see any change on the URLs of my test site. It still shows the HTML code for smilies and quotation marks. Did I make a mistake?

(Update: I just made a search, and I don't see any file from July 20+, so, I guess the file that is published is still the old file? I am using http://users.tpg.com.au/staer/Downloads/ShortURLs-pn0.76.zip).

On the other hand, about gallery, probably I didn't explain well, but on the standard gallery package (I am using the last 1.5x version), there is no PN ShortURLs support, but in their forum they give you some rules to add to .htaccess and to Xanthia's outputfilter to get the support, and I do get the ShortURLs (look for the "Galería" link on my site), but I don't get the same on your ShortURLs.

Sorry if I don't provide additional information, but I can do it if you need.

About internationalization, I now understand that the links are displayed with right characters, but they change on the copy/paste. Not a big deal, I guess.

Again, thank you very much for your work/help!

Imoq.

I never understood the big deal with this. Pass the information in a variable not in the URL, URL should be like a family tree like it truly is on the server. Use javascript so the variable is temporary if need be.

bri:

I don't think I understood your post.

msandersen:

I hope you have the chance to look at my previous post ;)

Cheers.

Sorry, I've had trouble with the internet the past few days, haven't been able to get on. I think it's fixed now; I was getting withdrawal symptoms!
While I was offline, I spent some time looking into Gallery a bit, it's a complex program. I found a few issues with pn0.75+ that needed fixing. The integration script is out of date, and doesn't work fully in the latest versions of PN, since it relies on outdated methods and functions that has been removed from PN. I'll upload the update and post a patch to the Gallery home page later.
I also modified it to have native ShortURLs much like the standalone Gallery, eg
/gallery/albumname/function.phtml eg /gallery/Family/slideshow.html or
/gallery/albumname/view-picturename.phtml

I didn't understand Bri's post either :) I don't think he understood my original post.

msandersen:

Wow! It is great that you are taking the time to even working with gallery, thanks a lot!

On the other hand, do you have a chance to take a look to the message I wrote before my last one? I used the new ShortURLs file you uploaded, but my stories are still showing with the "img src" code and the quotes are still converted to "&quot". Probably I am just forgetting something.

Thank you very much for your help! :)

I have tried to implement the new short URL's
I get an error 500 - internal server error.

If I delete the .htaccess file everything is ok.
I checked with the host, they say mod_rewrite is enabled.

Any ideas what I'm doing wrong?
Beano

beancounter3, yes I have an idea. The 500 error means it encoutered a rule it didn't like. In some of my earlier posts I mentioned that I only have Apache2 to test on, but suspected 2 of the PostCalendar rules could cause a problem on Apache 1.3, which is still very widespread. No-one so far has confirmed or disproved it yet. Maybe you can do that.
So, open the .htaccess file in a text editor, and find the 3rd Party section. The 3rd and 4th PostCalendar rules are the likely culprits (the comment in the file only mentions the 4th rule). I've tried to write the rules to be compatible with the older Regular Expression library (which is what the rules are written in) of Apache 1.3, but wasn't sure if it supported one particular feature. It would mean adding some more rules, which I was trying to avoid.

If you don't use PostCalendar, simply comment out (add # in front) or remove these rules altogether.

Imoq,
Did you install the update above called pn0.76-ShortURL-update.zip? It's a small patch. It has a modified stories block and News file among other things. For instance, the file /modules/News/func.php at line 200 has:
It should filter out all HTML tags. The stories block has the same change. I don't have the Smilie thing enabled, so I'm not sure what it does, I assume it parses the text smilies : ) to smilie image links.

The Gallery update for the current Gallery Beta 1.5.1 is here. The older one I provided was for 1.5, and was just for the URLs. This has updates for user and stylesheet integration.
The htaccess rules, to go in the 3rd party section, are:

I had a look at Gallery2 integration, but the project, pnGallery2, hasn't been updated since January, and the User and Group synchronisation isn't done yet. So I guess Gallery 1.5.1 is the best for now.

I had a closer look at the sorts of characters that should be filtered out or replaced in a title.
Whether it's a good or bad idea to have a story title in the URL is still up for debate, I guess it depends. Describtive and concise titles should be fine, but overly long ones with non-Ascii characters might not look so good. So maybe an option Whether to use them would be good.
Most other nonalphabetical characters will be URL-encoded, these are special cases. I've left things like () and [] out at this point.

msandersen:

You are right, I didn't update the other files and that's why it wasn't working. I had to take down my test site since the web spiders found it and it was starting to get published, hehe. I tried to send them away with robots.txt but it was already done, so, I just redirected the test to the main site and will have a non-public test site now. I really appreciate your work and will give feedback as soon as I have.

On the other hand, it is great that you added the rules for gallery 1.5x. Don't even bother about G2, since the integration is stopped for many, many months and if nobody picks it up it will NOT support PostNuke once it is realeased :( I have asked people here and there (in this forum and in Gallery's forum) but nobody seems to want/be able to take the job. Oh, well, we will have to live with gallery 1.x instead hehe.

I'll report back when I have something, thank you very much again!

Imoq.

oh, I'm sure someone will take up the slack for PN G2 integration at some point. The HDTV site hasn't said it's discontinued I don't think, they just haven't been heard from for a while! There's a test pnGallery2 test site, still nothing going on there, but they may intend to get back to it. It's mostly done anyway, it's based on the Xaraya integration code, but is incomplete. Still lots of mentions of Xaraya, and Xaraya-specific code, in there. G2 is a LOT more complex, but has a well-thought-out integration mechanism for all sorts of CMSes, so can be extended without messing with the core. Pretty neat.

I tried taking out postcalendar as suggested, but this has made no difference.
Still get the same error 500.
It is likely something very simple I am doing wrong, as I have very little technical knowledge.