Zikula Community

• **unknown user**
  
  

  • Rank: Freshman
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 52

  Posted: Jan 20, 2005 - 11:49 AM

  Is there a reason why pnVarPrepForStore has been moved out of the SQL statements and into a list prior to the SQL statements in the Example module?
  
  The Template module used pnVarPrepForStore right in the SQL statement and that seems like the more efficient method. I am not sure why this was changed, unless it presents a security flaw.

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Jan 21, 2005 - 04:08 AM

  This was a case of simplifying the code a little bit to aid readability. All the pnVarPrep* API's handle arrays as input and will act accordingly on each element of that array. So it made sense to call pnVarPrepForStore once with each of the values. This simplifies the SQL statement by having the data pre-prepped for the database
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• **unknown user**
  
  

  • Rank: Freshman
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 52

  Posted: Jan 22, 2005 - 09:28 AM

  Thanks Mark. I wonder if improving the simplicity of the SQL statement (having the data pre-prepped for the database) translates into improved performance. It must, but then how would one measure this, read/write time of SQL execution?

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Jan 22, 2005 - 12:45 PM

  Given all of the work is done before supplying the query to adodb there is actually no difference to performence. The use of pnVarPrepForStore in the SQL statement of the template module doesn't make any difference to ADODB. There may be a minor performence improvement by only calling pnVarPrepForStore only once but the difference will be minor.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
•  
•  

Users on-line

• 0 users

This list is based on users active over the last 60 minutes.