Dizkus

OK, change the code on lines 30-33 from this:


to this:


Then it will work.

-Chris

Or this if there is a problem with using the forward slash:


-Chris

Fixed my problem with banners. Thank you!!!

Cheers,
Stretchr :D

--
"It's a small world...
But I wouldn't want to paint it!"
Stephen Wright

First, thanks for your fixes, Chris. They solved one of my banner problems. My only remaining problem is that I cannot seem to be able to modify any of my existing banners. In Banner Management I can edit the individual clients but there's nowhere to edit the actual banners any more. Have you, or anyone else, solved this? Thanks!
Stretchr

--
"It's a small world...
But I wouldn't want to paint it!"
Stephen Wright

Somehow I must have missed that one. I'll look at it later today if someone hasn't already fixed it.
-Chris

Ok, the whole modules/NS-Banners/admin.php file was a total mess. I've fixed the bugs and cleaned up the SQL portions of the files. I've also gone back and cleaned up the banners.php file. Rather than post 1100+ lines of code in this message I'll post the link to where you can download the fixed version.

Get the fixed version here.

This link is to the NOC bug tracker, so it will eventually become a dead link. But at that time the fix will be incorporated into the normal download.

-Chris

chris,
did you check against the latest sources from the CVS? can you provide a diff with your changes?

--
regards from germany
..::[Zikula Application Framework]::.. ..::[SEO-Blog]::.. ..::[CMS Sicherheit]::..

I haven't checked CVS. Probably should have done that. I'll need to figure out how to get the .750 code from CVS, all I've ever gotten out of CVS is the . 8 code. As far as a diff goes I assume you want a diff comparing the version in CVS to my version. I can do that after I get the CVS code.

The file I uploaded has the whole module in it. I did it that way so people who wanted to fix the module on their site without dealing with cvs or diff files could just download the files and go.

The only files that have been modified though are the:
banners.php
includes/blocks/banners.php
modules/NS-Banners/admin.php

I'll work on getting a diff file.
It probably won't be for a few hours though.

-Chris

Chris,

I'd fixed a couple of banners bugs in cvs but maybe not all of them since I don't actually use this module myself....

BTW. As we discussed recently i've just asked Drak to contact you regarding joining the dev team so you should hear from him later today.

-Mark

I don't really use it all that much myself either, but I figured somebody had to fix it :)

Thanks for the update.

-Chris

it's just that i've added a couple of fixes for the SQL-statements, too (especially typecasting and removal of the deprecated queryutil.php stuff) - and the current (CVS) banner module is working on my site

--
regards from germany
..::[Zikula Application Framework]::.. ..::[SEO-Blog]::.. ..::[CMS Sicherheit]::..

Ok the diffs and the modified version that add Larsneo's type casting have been uploaded to the same location listed above. The changes that I made are almost identical to the changes that Mark and Larsneo made, with the exception that I changed all the SQL lines to be easier to read and debug. I really think you'll prefer my version when it comes to changing or debugging the code later.

Marks include/blocks/banners.php file still won't work though. I have modified that as well. If you try going to http://www.example.com/banners.php and there is a banner block active you will get a page that says "You can't access this file directly" with Marks current code since the file that you are accessing happens to be named identical to the name of the block file (banners.php).

-Chris

I used the latest banners2.tar.gz file and it appears to have fixed all the problems I encountered. Thank you for looking into this and fixing it!

Cheers,
Stretchr

--
"It's a small world...
But I wouldn't want to paint it!"
Stephen Wright

BTW - Adding this

seemed to fix the downloads module problem.