Fork me on GitHub

Critics  Bottom

  • I don't mean to offend anybody, but postnuke has one of the worst code structure that i have seen. Config variables spread all over the files (in config.php, then in pninit and so on), function that have one line
    (can somebody explain me what is the use of the function:
    function pninclude_once($file)
    {
    include_once($file);
    }
    icon_lol ) - if you are trying to make function that rewrites PHP functions just for API sake, why don't you made also a function pndate($date) { return date($date); } or even better - a genial ideea: pnecho($string) { echo($string) } icon_lol .
    It's nice that you want to have an API function list for your application, but try to restrict those functions only to ones that are really needed. Because someone writing modules would rather use PHP native functions (which you are more likely to be known than your API functions).
    Also trying to incorporate adodb it isn't neccesary here (look at the DB classes from phpbb, much more modular and well written).
    And finally, what's the use of base64_encode to database user and database password? I saw that you have pnencoding=1 before installation (maybe you try to make the user install the postnuke through install script and not manually) and 0 after. Or maybe you are afraid of the security of the data in the time the script is installed :?:
  • Are you talking about the .726 or .8 code base? AFAIK, there has been a lot of effort put into cleaning up the .8 code. Check it out via the CVS viewer.
  • 0 users

This list is based on users active over the last 60 minutes.