Zikula Community

• Slugger
  
  

  • Rank: Expert
  • Registered: Mar 11, 2003
  • Last visit: Oct 21, 2009
  • Posts: 1104

  Posted: Jul 15, 2003 - 02:13 PM

  I'm having a second go around with this theme and I can't believe it's possible that others haven'e experienced the errors I've seen.
  
  With the news set as the home page, the left column, the one with "POSTNUKE" written in vertical orientation. is as wide as the right blocks. Scrolling down below the fold I can see two of the blocks I set for the right side (one a banner block the other, the "Other Stories" block, directly below the left column. I'd guess they're responsible for "expanding" the left column but they don't belong there.
  
  I found one image, headerbottbg.gif, that wasn't being "seen" because the theme.php was "looking" for HeaderBottbg.gif. I fixed that but it had nothing to do with the other, more annoying, problem.
  
  I've tried to use this theme in two diffent settings with two diffent versions of postnukes and I've had the same problem both times. It has potential, which is why I've even bothered to revisit it, but (at least my copy) seems to have a lot of problems.
  
  Has anybody dealt with this? Is there a version of this theme floating around that doesn't have these bugs?

  • 
  •  
• **unknown user**
  
  

  • Rank: Helper
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 676

  Posted: Jul 16, 2003 - 10:51 AM

  There's nothing wrong with the tables in the theme as far as I can tell. These things usually happen with broken blocks, where there's an uneven number of opening table tags to closing tags. Just had a go at the Encyclopedia module, and on the search page, it tries to close two non-existing tables, causing the same problem.
  
  What's the last block that displays correctly, and where can I download it? Is the banner block the first one that's broken out of the table? Try disbling them in turn and see what happens. If the problem goes away, you've found your culprit.
  
  If so, look at the browser source, and see what it says for it between the
  
  and
  
  comments. Likelihood is, something about this block produces extra tags or the like, breaking the table. If nothing else, post the browser source of the two blocks either side of the "break".
  
  The theme has been updated with various changes to the code, with little visual difference, but I don't think there's anything that should make a difference to a broken block, unless DIVs keeps it in place. You can get it below.
  
  The image case has been fixed. That's a disadvantage perhaps of Windows, it's case-insensitive.
  
  Martin :D

  • 
  •  
• **unknown user**
  
  

  • Rank: Helper
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 676

  Posted: Jul 16, 2003 - 07:48 PM

  Having slept on it, I do have a theory of how the theme could have caused it. I can't test it as the relevant code was removed when I recently optimised the code. It was left over from the original, but I'd left it in as I don't like to assume I know better. Basically, it was an if statement that removed a portion of the table in the right block if there was no title. As I have no blocks without titles, it's never been tested. That could also explain why nobody else has encountered it.
  So, does the block that breaks the table, say the ad banner block, not have a title? If not, download the most recent version below and see if it is fixed.
  
  Martin :D

  • 
  •  
• Slugger
  
  

  • Rank: Expert
  • Registered: Mar 11, 2003
  • Last visit: Oct 21, 2009
  • Posts: 1104

  Posted: Aug 05, 2003 - 07:26 AM

  I'm guilty! Sometimes it's pretty obvious what the block is and, in those cases, the title is superfluous and (I think) makes the site look less manicured. I haven't had time to download or play with the theme but I'm betting you found what was causing the problem. As always, Martin, I appreciate your dedication and I particularly appreciate your efforts toward short URLs and improving so many themes. Thanks again.
  
  Slugger

  • 
  •  
• **unknown user**
  
  

  • Rank: Helper
  • Registered: Mar 16, 2002
  • Last visit: Oct 21, 2009
  • Posts: 676

  Posted: Aug 05, 2003 - 11:39 PM

  No problem. I hadn't looked at it for a while, and I should have tested it, just never came up. As mentioned, I went and made a bunch of subtle changes, like the right block and background, but most notably in the legibility of the source code for the news article sections (themeindex and article). You'll know if you do download it. A minor change was made to the rewrite rules when I upgraded to PN 0.726, I found a rule that broke in Sections. Do let me know if there are any others.
  
  Martin :D

  • 
  •  
• Slugger
  
  

  • Rank: Expert
  • Registered: Mar 11, 2003
  • Last visit: Oct 21, 2009
  • Posts: 1104

  Posted: Aug 08, 2003 - 04:12 AM

  Martin,
  
  I had a chance to upload and test your changes and the Theme worked flawlessly!
  
  Since you are the "Guru" of themes let me toss a couple of questions at you. First, I noticed that a lot of the short URL hacks mention something about hiding email addresses...whats that all about? Second, though not really a theme issue I'm betting you know the answer, why would the latest .7.2.6 update not render HTML in my Admin messages' titles? I used to highlite certain words in the titles with color, font size, italics, etc. but I can't do that anymore. I checked the settings and they're the same that I had in RC3, which was the last time it rendered correctly. I'm sure this is a side-effect of a security upgrade but since Admin messages cannot be posted by just anyone, I wonder if this is really necessary or if it can be bypassed. Any thoughts on this?
  
  Thanks again,
  
  Slugger

  • 
  •  
•  
•  

Users on-line

• 0 users

This list is based on users active over the last 60 minutes.