Zikula Community

• **unknown user**
  
  

  • Rank: Registered User
  • Registered: Mar 16, 2002
  • Last visit: May 02, 2003
  • Posts: 8

  Posted: Apr 28, 2003 - 04:45 AM

  I am developing a module and trying to make it portable by using classes. I basically want to include those classes in the pninit, pntables, and user/admin files. Is there a special way to do this? I am just using:
  
  

  Code

  $ModName = basename( dirname( __file__ ) );
  require_once("modules/$ModName/classes/classes.inc.php");

  
  
  and doesn't seem to be working. Any suggestions?

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Apr 28, 2003 - 10:09 AM

  The include in your code is relative to the location of the current file so if the file that this call is from is in your module then the code should look like
  
  

  Code

  require_once("classes/classes.inc.php");

  
  
  You don't actually need to evaluate the module directory.
  
  -Mark

  • 
  •  
• **unknown user**
  
  

  • Rank: Registered User
  • Registered: Mar 16, 2002
  • Last visit: May 02, 2003
  • Posts: 8

  Posted: Apr 28, 2003 - 11:01 AM

  Not sure if that is true as modules are loaded through index.php right?

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Apr 28, 2003 - 11:12 AM

  chrisabruce

  Not sure if that is true as modules are loaded through index.php right?

  
  
  As an entry point yes. But __FILE__ still evaulautes to the actual file your in.
  
  I know this to be the case as i've recently written a module utilising a class. See this file in CVS for an example.
  
  -Mark

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Posts: 1966

  Posted: Nov 19, 2003 - 09:30 AM

  markwest

  I know this to be the case as i've recently written a module utilising a class. See this file in CVS for an example.

  
  
  mark, I'm wondering if this is still the case as I think I've found the newest vrsion of the referenced file above here and the require_once statement seems to be different than you outlined.
  
  I bring this up because I am having similar troubles with a mod I am working on.

  • 
  •  
• ctimmer
  
  

  • Rank: Softmore
  • Registered: Feb 07, 2003
  • Last visit: Jun 11, 2008
  • Posts: 225

  Posted: Nov 19, 2003 - 10:29 AM

  When I left out the 'modules/Recipe/...' in my Recipe module, the includes worked OK 95% of the time. Had to put it back in. This was for class include files also.
  
  You might display your include path to make sure it is what you expect it to be.

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Posts: 1966

  Posted: Nov 19, 2003 - 10:46 AM

  yeah - well, it appears to be going to the root of the harddrive!
  Something like

  Code

  require_once("classes/myclass.php");

  looked in the root of the drive - not even the root of the web server! eek!

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Nov 19, 2003 - 11:56 AM

  To bring this up to date on this issue my current recomendations are to look from the perspective of the root file that will launch your module. This will always be either index.php or modules.php so reference all inlcudes from this point. The way to look at this is that all files including your module code are 'included' into index.php (or modules.php) at some point so reference all includes from the site root.
  
  There are some php.ini settings that mean you can do refer to it from the current file but this will not translate accurately across PHP installs. As Craig has pointed out i've changed this mailer code since this post. This is to reflect my further experience on this issue.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Posts: 1966

  Posted: Nov 19, 2003 - 12:34 PM

  Thanks Mark! - quick followup question:
  
  in the pninit file for a mod, can I use something like:

  Code

  $path="/modules/$module/foo/bar";

  If so, how do I get $module? Since pninit runs from the "modules" module, I get "modules" from pnModGetName()...
  
  thanks!

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Nov 19, 2003 - 12:52 PM

  As an API compliant module can't be renamed due to the function calls containing the module name then I would suggest simply putting the module name here. I can't think of any 100% automated way of doing this. There are ways that will work some of the time but not 100% hence the way the API compliant structure works.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Posts: 1966

  Posted: Nov 19, 2003 - 12:56 PM

  thanks, Mark, for the quick answer. You are an officer and a gentleman... :)

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Nov 19, 2003 - 01:03 PM

  I've know several people that would dispute that comment...... ;)
  
  Seriously though i'm looking through the pnCopiliot module at the moment and will have some feedback for you by the weekend.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.

  • 
  •  
• craigh
  
  

  • Rank: Developer
  • Registered: Jun 16, 2003
  • Posts: 1966

  Posted: Nov 19, 2003 - 01:07 PM

  thanks - that's what I'm working on and why this issue came up. my co-developer/friend is insisting that

  Code

  $ModName = basename( dirname( __file__ ) );
  require_once("modules/$ModName/classes/classes.inc.php");

  is the better solution than hardcoding the mod name - your thoughts?

  • 
  •  
• HalbrookTech
  
  

  • Rank: Developer
  • Registered: Dec 31, 1969
  • Last visit: Jun 01, 2010
  • Posts: 6859

  Posted: Nov 19, 2003 - 05:44 PM

  As Mark said, the Module name can;t change with out code changes, so it can be hard coded.
  
  --
  Home Page | Find on Facebook | Follow on Twitter
  

  • 
  •  
• markwest
  
  

  • Rank: Team Member
  • Registered: Mar 18, 2002
  • Last visit: Oct 21, 2009
  • Posts: 6606

  Posted: Nov 19, 2003 - 08:31 PM

  You can use that as it will work but given each function name in a API compliant module is <modname>_* (e.g. modname_userapi_get or modname_admin_modifyconfig) then you don't gain anything from doing so. To rename the module requires a search and replace on the module name anyway.
  
  -Mark
  
  --
  Visit My homepage and Zikula themes.</modname>

  • 
  •  
•  
•  

Users on-line

• craigh

This list is based on users active over the last 60 minutes.