Dizkus

Hi,

I found comands that print invalid HTML-TAGS like "/>" (in metatag) and "
" in many files,
so that I ask myself, how this error could spread all over the installed sources.

Is there possibly an error in Installation-File (Tool to build the local implementation)?

Your Site here is also *infected*.

I have a list with the concerning PHP-Files, if you are interested.

I started to fix it manually, but the list get's longer an longer...
So I want to ask wether there is a fix already or whether I have made a fundamental error whilst installation?

I use Phoenix 7.0.2.3 + Security Update + PostNuke Calendar.

Anyone who recognized this phaenomena also?

gap

The tags your seeing are valid XHTML tags. The core code is a bit of state of flux at the moment and is a mix of HTML and XHTML.

The introduction of the templating engine will go a long way towards tidy this up and make sure that we have either HTML or XHTML and not a mix.

Hope this answers the question.

-Mark

Hi Mark,

thank's for your quick answer :)

XHTML-Tags:
Isn't it necessary to declare a special Type of Document then?

Now we declared:


I admit, that I don't know XHTML very well yet ;)

What happens, if I change all occurences from "/>" to ">"?
Will I get problems with a in that way modified version?

-gap

Yes it is necessary to declare the doc type and XHTML codes are not valid in the HTML doc type and vice versa. So at the moment using either XHTML or HTML as a doc type will get you errors if you attempt to validate the page.

My understanding of how this came about is limited as i've only been on the dev team for a couple of months now.

If you remove the / from the relevant files then you should get closer to valid HTML page or alternatively go the other way and add the relevant doc type and the / to each of the tags in each module.

The issue will be gradually addressed as we implement the templating engine in the core and then template each modules output.

I've still some reading to do myself on each of the standards. My knowledge is much more focussed in the code than the layout.

You can get full details of the doc types and assoicated standard from the W3C.

-Mark

I decided to change the XHTML-TAGS to regular HTML-TAGS.

Here's my report, for those to whom it may concern...

-gap
------------------------
1. Database-Content:

I changed the existing messages and articles with the
following statement:

update nuke_stories
set pn_hometext = replace(pn_hometext,' />','>');
update nuke_stories
set pn_hometext = replace(pn_hometext,'/>','>');
update nuke_stories
set pn_bodytext = replace(pn_bodytext,' />','>');
update nuke_stories
set pn_bodytext = replace(pn_bodytext,'/>','>');
update nuke_message
set pn_content = replace(pn_content,' />','>');
update nuke_message
set pn_content = replace(pn_content,'/>','>');

---------------------
2. PHP and other Source-Files:

Here's the list of Files, that have to be changed.
I got it by a recursive grep-Command on the PostNuke-Directories:

grep -ir "/>" * >found_slashes.info

banner.php
header.php
error.php
includes/blocks/big.php
includes/blocks/button.php
includes/blocks/category.php
includes/blocks/ephem.php
includes/blocks/finclude.php
includes/blocks/fxp.php
includes/blocks/login.php
includes/blocks/menu.php
includes/blocks/online.php
includes/blocks/poll.php
includes/language/blocks/deu/past.php:
includes/pnHTML.php
includes/textsanitizer.php
includes/xhtml.php:
install/check.php
install/gui.php
install/lang/deu/global.php
install/lang/eng/global.php
install/modify_config.php
install/newdata.php
install/pn5.php
install/pn7.php
language/deu/error.php
language/deu/global.php
language/deu/user.php
language/eng/banners.php
language/eng/global.php
modules/Downloads/admin.php
modules/Downloads/dl-categories.php
modules/Downloads/dl-navigation.php
modules/Downloads/dl-rating.php
modules/Downloads/dl-util.php
modules/Downloads/lang/deu/global.php
modules/FAQ/index.php
modules/FAQ/admin.php:
modules/legal/lang/deu/global.php
modules/Messages/functions.php
modules/Modules/pnlang/deu/manual.html
modules/News/index.php
modules/NS-Admin/lang/deu/manual.html
modules/NS-Banners/admin.php
modules/NS-Comments/index.php
modules/NS-Comments/lang/deu/global.php
modules/NS-Languages/admin.php
modules/NS-NewUser/lang/deu/global.php
modules/NS-Polls/admin.php
modules/NS-Referers/admin.php
modules/NS-Settings/admin.php
modules/NS-Settings/lang/deu/global.php
modules/NS-User/admin.php
modules/NS-User/lang/deu/global.php
modules/NS-User/user/menu.php
modules/NS-Your_Account/user/modules/changehome.php
modules/PostCalendar/common.api.php
modules/PostCalendar/plugins/function.pc_date_select.php
modules/PostCalendar/plugins/function.pc_filter.php
modules/PostCalendar/plugins/function.pc_form_nav_close.php
modules/PostCalendar/plugins/function.pc_view_select.php
modules/PostCalendar/pnblocks/calendar.php
modules/PostCalendar/pnuser.php
modules/PostCalendar/pntemplates/default/user/usermenu.html
modules/PostCalendar/pntemplates/default/user/submit.html
modules/PostCalendar/pntemplates/default/user/details.html
modules/PostCalendar/pntemplates/default/user/search.html
modules/PostCalendar/pntemplates/default/user/preview.html
modules/PostCalendar/pntemplates/default/admin/submit.html
modules/PostCalendar/pntemplates/default/admin/details.html
modules/PostCalendar/pntemplates/default/views/day/default.html
modules/PostCalendar/pntemplates/default/views/week/default.html
modules/PostCalendar/pntemplates/default/views/month/default.html
modules/PostCalendar/pntemplates/default/views/month/list.html
modules/PostCalendar/pntemplates/default/views/calendarblock/todays_events.html
modules/PostCalendar/pntemplates/default/views/calendarblock/month_view.html
modules/PostCalendar/pntemplates/default/views/calendarblock/upcoming_events.html
modules/PostCalendar/pntemplates/default/views/global/navigation.html
modules/PostCalendar/pnadmin.php
modules/PostCalendar/pnadminapi.php
modules/PostCalendar/print.php
modules/Ratings/pnlang/eng/manual.html
modules/Recommend_Us/index.php
modules/Recommend_Us/lang/deu/global.php
modules/Reviews/lang/deu/global.php
modules/Sections/admin.php
modules/Sections/index.php
modules/Stats/index.php
modules/Submit_News/lang/deu/global.php
modules/Topics/admin.php
modules/Web_Links/admin.php
modules/Web_Links/lang/deu/global.php
modules/Web_Links/wl-addlink.php
modules/Web_Links/wl-categories.php
modules/Web_Links/wl-linkdetails.php
modules/Web_Links/wl-linkeditorial.php
modules/Web_Links/wl-mostpopular.php
modules/Web_Links/wl-navigation.php
modules/Web_Links/wl-newlinks.php
modules/Web_Links/wl-rating.php
modules/Web_Links/wl-util.php
modules/Web_Links/wl-viewlink.php:
modules/Wiki/pnuserapi.php
modules/xmlrpc/lib/xmlrpc.inc
pnadodb/adodb.inc.php
pnadodb/readme.htm
print.php